Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single button to toggle filters #6

Closed
tacocat opened this issue Dec 19, 2017 · 2 comments
Closed

Single button to toggle filters #6

tacocat opened this issue Dec 19, 2017 · 2 comments

Comments

@tacocat
Copy link
Contributor

tacocat commented Dec 19, 2017

Dimension/metric filters are added with one button, and removed through another. It's natural to try and click the "add filter" icon to toggle it off once the filter is already there.
@balajimanoharan
Copy link
Contributor

balajimanoharan commented Dec 20, 2017 •
edited

This also depends on whether multiple filters of the same type going to be allowed, either with an or/and operation? How should that be communicated to the user to make it intuitive?

Also, would maybe a different icon such as this, https://www.iconfinder.com/icons/135333/add_filter_icon make it more clear to an user.

@balajimanoharan
Copy link
Contributor

This has been done. Will need to redesign when we decide on multiple filters for the same dimension, but for now, this is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tacocat @balajimanoharan