Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix custom attributes #21

Closed
MarcinOrlowski opened this issue May 5, 2016 · 3 comments
Closed

Prefix custom attributes #21

MarcinOrlowski opened this issue May 5, 2016 · 3 comments

Comments

@MarcinOrlowski
Copy link

Id' recommend prefixing all custom attributes with i.e. fsd_ or anything like that to avoid potential clash with other libraries in the project.

@yavski
Copy link
Owner

yavski commented Oct 16, 2016

Thanks for the tip, for the sake of not breaking backwards compatibility I'll keep the existing attributes.

@yavski yavski closed this as completed Oct 16, 2016
@MarcinOrlowski
Copy link
Author

Thanks for the tip, for the sake of not breaking backwards compatibility

And what's wrong with non-backward compatible changes? Just document the change clearly, and properly bump the version

@yavski
Copy link
Owner

yavski commented Oct 17, 2016

@MarcinOrlowski It hasn't been brought up before, it doesn't seem to be an issue that other people are facing hence the cost doesn't seem to be justified. Are you having that issue yourself? With which library is the clash?
I'm considering doing a 1.1 where you can provide the menu items either statically via the menu resource (as it is at the minute), or dynamically via an adapter. Perhaps I can introduce that change then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants