Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching HTML source if no description is given #12

Closed
cbleek opened this issue Oct 19, 2017 · 4 comments
Closed

Fetching HTML source if no description is given #12

cbleek opened this issue Oct 19, 2017 · 4 comments

Comments

@cbleek
Copy link
Member

cbleek commented Oct 19, 2017

@fedys @TiSiE

adding a jobosting without a fulltext to solr makes no sense. So what can we do, if a job is activated and no html is given.

My idea is to simply fetch the html. If fetching fails, the job is not inserted.

Can we/should we do this in the solr module?

Keep in mind that all the time consuming tasks like fetching pages, inserting into solr, sending mails... should be moved into some queing system

@fedys
Copy link
Member

fedys commented Oct 20, 2017

I am not sure if the Solr module should be responsible for fetching an html. In my opinion the code which inserts an active Job should be responsible for a data completeness. If there is no description field in the import specification I would fetch an html in the SimpleImport module.

@cbleek
Copy link
Member Author

cbleek commented Oct 20, 2017

@TiSiE do you agree?

@TiSiE
Copy link
Member

TiSiE commented Oct 23, 2017

Yes, I do agree.

@cbleek
Copy link
Member Author

cbleek commented Oct 24, 2017

this will be done in yawik/SimpleImport#4

@cbleek cbleek closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants