Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailService: SMTP connections are restricted to SSL encryption #616

Closed
fquadt opened this issue Jan 30, 2018 · 0 comments
Closed

MailService: SMTP connections are restricted to SSL encryption #616

fquadt opened this issue Jan 30, 2018 · 0 comments

Comments

@fquadt
Copy link

fquadt commented Jan 30, 2018

At the moment the MailService only allows for SSL encrypted connections to the SMTP server. The used library simplemail does indeed support three transport strategies (PLAIN, SSL (default) and TLS).
It would be nice to make the transport strategy user configurable by a property.

The only code changes necessary are the new property and a modified constructor call of the Mailer class in MailService.java:
public Mailer(final String host, final int port, final String username, final String password, final TransportStrategy transportStrategy) {

Maybe, in the course of this ticket, it is a good idea to update the simplemail library (currently 1.8) to the newest version 4 or 5 since there have been some new TLS versions and SSL vulnerabilities...

@fquadt fquadt closed this as completed Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant