Build without recursive-nix
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veehaitch
force-pushed
the
recursive-nix-65
branch
3 times, most recently
from
7309e1c
to
3786463
Compare
|
GitHub stills seems to schedule the old workflow. I think we can just ignore that. |
veehaitch
force-pushed
the
recursive-nix-65
branch
from
25ee7d7
to
9a2d61d
Compare
vtuan10
previously approved these changes
Dec 27, 2021
The `recursive-nix` feature seems broken on macOS. We should revert this commit as soon as this issue is resolved. At last, `recursive-nix` is an experimental feature.
veehaitch
force-pushed
the
recursive-nix-65
branch
from
9a2d61d
to
390595e
Compare
|
Rebased. |
vtuan10
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code to allow building without
recursive-nix:recursive-nixare guarded by a feature flag which is enabled by default (to still run them by just executingcargo test).nix builddisables therecursive-nixfeature flag. This allows usingragenixwithout a system withrecursive-nixsupport.nix flake checkwill buildragenix(again) and run all tests.recursive-nixwhile the latter uses a Nix installation with therecursive-nixfeature enabled. Only the check workflow requiresrecursive-nix.recursive-nixchecks. I'm not sure what's the reason but it is probably an upstream bug. Therefore, I moved the respective checks to the Linux check outputs. We can revert the commit as soon as this is addressed.Fixes #65