feat(eslint): move .eslintrc.js to package.json (#278)

BREAKING CHANGE: remove `.eslintrc.js` file

lib/init.js

@@ -6,8 +6,6 @@ const originalPackage = require("../package.json");
 const packagePath = (...pathElements) =>
   path.join(...[__dirname, "..", ...pathElements]);
 
-const template = name => path.join(__dirname, "..", "templates", name);
-
 class Init {
   constructor(baseDir, logger) {
     this.baseDir = baseDir;
@@ -64,14 +62,13 @@ class Init {
     packageInfo.commitlint = {
       extends: ["@commitlint/config-conventional"],
     };
+    packageInfo.eslintConfig = {
+      extends: ["ybiquitous"],
+    };
 
     await this.writeFile("package.json", JSON.stringify(packageInfo, null, 2));
   }
 
-  async writeTemplateFile(name) {
-    await this.copyFile(template(name), this.currentPath(name));
-  }
-
   async writePackageFile(name) {
     await this.copyFile(packagePath(name), this.currentPath(name));
   }
@@ -87,10 +84,8 @@ module.exports = async function init({
   await cmd.updatePackageFile();
   await cmd.writePackageFile(".editorconfig");
   await cmd.writePackageFile(".markdownlint.json");
-  await cmd.writeTemplateFile(".eslintrc.js");
 };
 
 module.exports.desc = `Setup npm project:
 - Update 'package.json'
-- Create '.editorconfig'
-- Create '.eslintrc.js'`;
+- Create '.editorconfig'`;

package.json

@@ -16,7 +16,6 @@
   "files": [
     "bin",
     "lib",
-    "templates",
     ".editorconfig",
     ".markdownlint.json"
   ],

test/fixtures/package-empty_expected.json

@@ -31,5 +31,8 @@
   },
   "commitlint": {
     "extends": ["@commitlint/config-conventional"]
+  },
+  "eslintConfig": {
+    "extends": ["ybiquitous"]
   }
 }

test/fixtures/package-normal.json

@@ -8,5 +8,8 @@
   },
   "commitlint": {
     "extends": []
+  },
+  "eslintConfig": {
+    "extends": []
   }
 }

test/fixtures/package-normal_expected.json

@@ -32,5 +32,8 @@
   },
   "commitlint": {
     "extends": ["@commitlint/config-conventional"]
+  },
+  "eslintConfig": {
+    "extends": ["ybiquitous"]
   }
 }

test/help.test.js

@@ -8,7 +8,6 @@ Commands:
   cli.js init  Setup npm project:
                - Update 'package.json'
                - Create '.editorconfig'
-               - Create '.eslintrc.js'
 
 Options:
   --help, -h     Show help                                             [boolean]

test/init.test.js

@@ -79,17 +79,6 @@ test("init", t => {
     });
   });
 
-  testInSandbox('write ".eslintrc.js"', async (t, ctx) => {
-    await ctx.fixture("package-normal.json");
-    await init(ctx.initArgs);
-    t.ok(ctx.logMessage().includes(".eslintrc.js was updated."));
-
-    const actual = await ctx.readWorkFile(".eslintrc.js");
-    const expected = await ctx.readFixture(".eslintrc_expected.js");
-    t.is(actual, expected);
-    t.end();
-  });
-
   testInSandbox("throw error if no package.json", async (t, ctx) => {
     const error = await init(ctx.initArgs).catch(err => err);
     t.ok(error instanceof Error);