Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileReport fails if dataframe contains boolean columns #77

Closed
Aylr opened this issue Dec 15, 2017 · 8 comments
Closed

ProfileReport fails if dataframe contains boolean columns #77

Aylr opened this issue Dec 15, 2017 · 8 comments

Comments

@Aylr
Copy link
Contributor

Aylr commented Dec 15, 2017

Despite #25 and #64 , this appears to still be an issue.

Steps to reproduce

foo = pd.DataFrame({
    'a': [1, 2, 3],
    'bool': [True, False, True],
})

# fails
pandas_profiling.ProfileReport(foo)

# succeeds (convert to integer)
foo['bool'] = np.where(foo['bool'], 1, 0)
pandas_profiling.ProfileReport(foo)

Does anyone have any suggestions before I submit a PR?

@Aylr Aylr changed the title ProfileReport fails if dataframe contains bool columns ProfileReport fails if dataframe contains boolean columns Dec 19, 2017
@conradoqg
Copy link
Contributor

I wasn't able to reproduce this problem with the latest commit.

Could you give more details about your environment?

My:

CPython 3.6.0
IPython 6.2.1

pandas 0.19.2
numpy 1.13.3
matplotlib 2.1.0
six 1.11.0

compiler   : MSC v.1900 64 bit (AMD64)
system     : Windows
release    : 10
machine    : AMD64
processor  : Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
CPU cores  : 8
interpreter: 64bit
Git hash   : bc52a3cc10863c54c592210e86989d3ef733f138

Best

@romainx
Copy link
Contributor

romainx commented Jan 1, 2018

I confirm, I'm not able to reproduce the problem in my environment.
Could you also share the error observed?

Thanks

@Aylr
Copy link
Contributor Author

Aylr commented Jan 2, 2018

I was not able to reproduce this! When I was certain I could it turned out ipython must have been caching a non-master branch of the library.

From (another) clean environment I was able to get both code snippets above to work.

Sorry about the user error!!

@Aylr Aylr closed this as completed Jan 2, 2018
@Aylr
Copy link
Contributor Author

Aylr commented Jan 2, 2018

Since it's been almost a year since the last release when can we expect a new one on pypi? 😄

@conradoqg
Copy link
Contributor

Hey,

I think a new release is a good idea but before that, this month I hope to be able to do a series of new features and bug fixes.

If the authors can wait a week, I think the most important ones will be ready.

Best

@romainx
Copy link
Contributor

romainx commented Jan 2, 2018

Hello,

I'm not the author, but I agree. I think new features are mandatory before delivering a new version and I will help improving it. On my side I would be happy to improve testing and CI.

We have to check with @JosPolfliet his target date. In my point of view we should commit to issue a new version before the end of the first quarter 😄.

@conradoqg
Copy link
Contributor

Hey,

I'm confident that after the PR #82 we don't have any more problems with bool variables.

@romainx Can you open a specific issue to release a new version (maybe we can create a list of desired improvements/issues to be fixed).

I think we can close this issue after those changes.

Best

@romainx
Copy link
Contributor

romainx commented Jan 6, 2018

Hello,

I've created a new one (#86) to publish a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants