New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate pdoc-based documentation page #982
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #982 +/- ##
========================================
Coverage 90.80% 90.80%
========================================
Files 169 169
Lines 4653 4653
========================================
Hits 4225 4225
Misses 428 428
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@sbrugman Would any of the solutions here for the redirect be a viable option? https://superdevresources.com/redirects-jekyll-github-pages/ |
The challenge is not having to create individual redirects for each old page, while not having access to the normal server-side tools. We could create a 404 page that, when the URL contains /rtd/, redirects to the parent folder. |
I was checking with YData's infrastructure team and it's not easy to create server-side redirects given the way the website is currently set up. So, the two options I see are:
Both seem fine to me. Assuming it works, the extension would probably lead to a smoother experience. Any preference? |
Sphinx-redirect is preferable, as it can be maintained without modifying the GitHub Pages config. It supports directory redirects. |
@sbrugman Briefly played around with the extension and it doesn't exactly fit this use case without some convoluted workflows and poor generalisation if/when new pages are added (due to the way the wildcard and source matching works). Given that all the links in the repo have been updated (apart from those eventually present in GitHub issues), the problem would mainly manifest with external links from the web. I feel it's OK to redirect those to the main page (and hopefully the new docs structure will make it easy for everyone to find what they are looking for). In that case, from what I read on that StackOverflow page, I think a simple solution would be serving a cp docs/${{ env.BRANCH_NAME }}/index.html 404.html
git add 404.html Thoughts? |
Ok, let's go with the redirect. By default we can redirect urls that contain |
@sbrugman As we agreed, given the incoming docs restructuring branch, a lot of external URLs will be broken, it doesn't make as much sense as before to do the In that case, I am marking this branch as ready for review and creating a separate one with the 404 to merge into |
Sphinx with an RTD theme is the current documentation system. However, a pdoc3 -based documentation page is still up, although it's not being used. This branch deprecates it:
pdoc
related instructions from makefiles and similars.docs/rtd/
to/docs/
)Still missing:
/docs/rtd
to/docs/
(release CI/CD pipeline)