Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated functions? #37

Closed
dpavlic opened this issue Jan 21, 2017 · 3 comments
Closed

Duplicated functions? #37

dpavlic opened this issue Jan 21, 2017 · 3 comments

Comments

@dpavlic
Copy link
Contributor

dpavlic commented Jan 21, 2017

Hi Jos,

It seems to me there are (almost) duplicated functions in base.py with describe having inner functions that are almost identical to the outer functions. I've chopped those off, as seen here:

dpavlic@20df9e6

The tests all run and everything still generates as usual. Am I missing something, or can these go?

@tejaslodaya
Copy link
Contributor

IMO, these can go, for now. Because, the multiprocess_func calls describe_1d which is an outer function.
I think Jos wanted to build a seperate module for those describe_* functions, and didn't want any dependency on the core describe function.

@tejaslodaya
Copy link
Contributor

@dpavlic Why don't you issue a PR, and merge them. It sounds relevant for now.
CC: @JosPolfliet

@JosPolfliet
Copy link
Contributor

Thanks guys, I will take a look soon. Finishing up some other project and then this one has my primary attention again. Hopefully next week I will have some free hours to check this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants