Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new regular data model synthesizer CWGANGP #153

Merged
merged 6 commits into from Apr 18, 2022
Merged

feat: Add new regular data model synthesizer CWGANGP #153

merged 6 commits into from Apr 18, 2022

Conversation

jfsantos-ds
Copy link
Contributor

Adds a Conditional Wasserstein GAN with Gradient Penalty, together with an example file.

This PR also:

  • Fixes the column order in the sample method output of CGAN (label column was not being inserted in correct location)
  • Simplifies the logic of label_col property setting (use a validation method instead of property setter with tuple args)

Francisco Santos added 2 commits March 29, 2022 12:44
CWGANGP
f34eac5 
fix notation on wgan_gp properties

Simplify structure and notation on cwgan_gp

add CWGANGP to init

bug fixes

correct print message
fix column order in cgan sample
5bb7db4
@jfsantos-ds jfsantos-ds self-assigned this Mar 29, 2022
@jfsantos-ds

This comment was marked as resolved.

Sign in to view
@fabclmnt

This comment was marked as resolved.

Sign in to view
@jfsantos-ds jfsantos-ds changed the title feat/cwgangp feat: Add new regular data model CWGANGP Mar 30, 2022
fabclmnt
fabclmnt requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Load error fix.

Other than that nothing to add.

@jfsantos-ds
Copy link
Contributor Author

Related to the error in load, it seemed to be an error related to pickling.
I think the namedtuples were somehow not being stored properly on the subclassed synthesizer, despite no problems in the parent classes.
Changing the object to SimpleNamespaces solved this issue without changing any functionality.

more lint and disable D203 warning
3f34202 
D203 directly conflicts D211 and seems to be considered deprecated
@jfsantos-ds jfsantos-ds changed the title feat: Add new regular data model CWGANGP feat: Add new regular data model synthesizer CWGANGP Apr 4, 2022
fabclmnt
fabclmnt approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jfsantos-ds jfsantos-ds merged commit ae641a6 into dev Apr 18, 2022
@jfsantos-ds jfsantos-ds deleted the feat/cwgangp branch April 18, 2022 09:43
fabclmnt pushed a commit that referenced this pull request Apr 19, 2022
@jfsantos-ds
feat: Add new regular data model synthesizer CWGANGP (#153)
8d1311d 
* CWGANGP

* fix column order in cgan sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabclmnt fabclmnt fabclmnt approved these changes

@ubabe53 ubabe53 Awaiting requested review from ubabe53

Assignees

@jfsantos-ds jfsantos-ds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfsantos-ds @fabclmnt