Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock dataset is not available in Google Colab #221

Open
datatalking opened this issue Dec 30, 2022 · 5 comments
Open

Stock dataset is not available in Google Colab #221

datatalking opened this issue Dec 30, 2022 · 5 comments
Labels
question Further information is requested

Comments

@datatalking
Copy link

datatalking commented Dec 30, 2022

Describe the bug
Once I found a google colab to work I found that TimeGAN doesn't supply or reference the location of the data.

FileNotFoundError: [Errno 2] No such file or directory: 'sample_data/stock_data.csv'

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'TIME '
  2. Run code to the seventh cell, it generates the error shown below

Screenshots
Screen Shot 2022-12-29 at 8 33 44 PM

Desktop (please complete the following information):

  • MacOS: 11.3.1
  • Browser safari
@datatalking datatalking added the bug Something isn't working label Dec 30, 2022
@thewizardnet
Copy link

You can use any stock dataset like the one from yahoo finance. The original dataset from the paper is here https://github.com/jsyoon0823/TimeGAN/blob/master/data/stock_data.csv

@datatalking
Copy link
Author

You can use any stock dataset like the one from yahoo finance. The original dataset from the paper is here https://github.com/jsyoon0823/TimeGAN/blob/master/data/stock_data.csv

@thewizardnet do you accept PR's or add collaborators with this repo?

@fabclmnt
Copy link
Contributor

Hi @datatalking yes we do accept PR and the addition of collaborators!

Feel free to submit your PR! It is great to have you contributing :)

@datatalking
Copy link
Author

datatalking commented Mar 19, 2023

@fabclmnt what I'm thinking is that I could refactor the csv link_file within a parsing function so the user doesn't need to download it. Are you aware of any SSL or restrictions that require hardcoding the CSV file as an HTML, or does it need to be 'local' or 'root' for the google collab?

I had a separate question but was wondering if you could point me to the interwebs where I can find out how to access a google collab; how could a collab be 'started' and 'stopped' or run via an API as in scheduled with a cron job?

@fabclmnt
Copy link
Contributor

I'm not aware of the specifics around Google Colab to be honest.
Regarding the dataset itself we have a few datasets (such as the adult census dataset) that does not require the local file, and the data is download directly to the Colab space. Something similar could be done.

@fabclmnt fabclmnt added question Further information is requested and removed bug Something isn't working labels May 16, 2023
@fabclmnt fabclmnt changed the title [BUG] Stock dataset is not available in Google Colab May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants