New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finaliser for pool gc #150

Closed

rekby opened this issue Mar 10, 2022 · 1 comment

Member

rekby commented Mar 10, 2022

ydb-go-sdk/internal/conn/pool.go

Line 74 in 710f840

func (p *pool) Release(ctx context.Context) error {

I think about counter with implicit close object when counter = 0 is un-intuitive.

What about:

Write separate method Close() - for close logic and call it when close needed
Use runtime.SetFinalizer - for call implicit Close() if pool doesn't need
Add Hook OnClosed - can help determine call in tests example

Member

asmyasnikov commented Mar 10, 2022

all places for release pool are known. No need to use runtime.SetFinalizer

asmyasnikov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment