Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair cursor #11

Open
yds12 opened this issue Mar 18, 2023 · 8 comments
Open

Crosshair cursor #11

yds12 opened this issue Mar 18, 2023 · 8 comments
Labels
feature status: wip issue is being worked on

Comments

@yds12
Copy link
Owner

yds12 commented Mar 18, 2023

The current tool icons provide a quick way to see what tool you are using, but sometimes they may not be precise enough when it comes to seeing which pixel you are on. A crosshair cursor would be ideal for this (similar to the one used for the move tool).

For now, we need to decide when should this cursor be used:

  • for all tools
  • for some tools such as brush
  • activated/toggled with some keyboard shortcut or UI button

As we don't have yet configurability for shortcuts, we should decide how this can be used for the moment.

@yds12 yds12 added the enhancement New feature or request label Mar 18, 2023
@FlitneyR
Copy link

How about highlighting the current pixel under the cursor with a black outline? That's the first thing that came to mind for me when I first ran the program. I think this would make sense for the brush, bucket, eraser, eye dropper and line tool

@yds12
Copy link
Owner Author

yds12 commented Mar 18, 2023

It would have to be an outline like the one for the selection, which alternates between black and white (in black areas of the image a black outline would not be visible).

@yds12
Copy link
Owner Author

yds12 commented Apr 1, 2023

With the new changes on configurable controls, I think we can have a crosshair cursor that is activated by keeping a button pressed, it's trivial to implement now. Would be similar to the new PAN tool (hold SPACE + drag mouse) but simpler.

@crumblingstatue
Copy link
Contributor

It would be nice if it was also toggleable instead of having to hold down a button

@yds12
Copy link
Owner Author

yds12 commented Apr 6, 2023

Added: fecc999

To toggle the cursor, you can press C (this will be configurable soon). Let me know what you guys think, and if we can close this issue.

@crumblingstatue
Copy link
Contributor

Thank you, I'll try it out tomorrow!

@crumblingstatue
Copy link
Contributor

It's working, thank you!

@yds12
Copy link
Owner Author

yds12 commented Apr 7, 2023

@FlitneyR 's idea is also good, maybe we could make the pixel under the cursor blink/alternate between the current canvas color and the selected color, when using the crosshair cursor.

@yds12 yds12 added feature status: wip issue is being worked on and removed enhancement New feature or request labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature status: wip issue is being worked on
Projects
None yet
Development

No branches or pull requests

3 participants