New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target Size and QR Tags colorisation support #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 51.94% 52.22% +0.28%
==========================================
Files 22 22
Lines 1236 1256 +20
==========================================
+ Hits 642 656 +14
- Misses 594 600 +6
Continue to review full report at Codecov.
|
Great feature! Thank you. How can I use it in my project? |
Sorry to get back so late. Merged. |
Thanks. Did you also push a new version to cocoapods (pod trunk push...) so that @sotrosh just can do a "pod 'RSBarcodes_Swift'" ? |
No problem, working on it. |
🎉 Congrats 🚀 RSBarcodes_Swift (5.0.2) successfully published
|
Thank you for merge. Unfortunately, it doesn't work as expected. When I'm trying:
size is
|
Hmm. I just tested with version 5.0.2 in my own project and it still works... Need to have a deeper look into it. Did you try with other values? Is the image (even though it is small) a correct QR tag? |
I tested it some more and did not encounter an issue (also tested with 1000x1000 and got an image of size 500x500pt in scale 2 == 1000x1000px). |
Yeah, I tried the same thing in the sample code, it works as expected. |
Target size was added to the interface in order to scale the resulting image before it is converted into an UIImage. Scaling a UIImage results in pixellation, so the change is done on the CIImage.
Setting stroke and fill colours did not apply to CIFilter generated code tags. This is now supported.
The code changes are backwards compatible.