Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on multiplayer #5

Open
year6b7a opened this issue Jun 7, 2023 · 4 comments
Open

Test on multiplayer #5

year6b7a opened this issue Jun 7, 2023 · 4 comments

Comments

@year6b7a
Copy link
Owner

year6b7a commented Jun 7, 2023

While nothing jumps out to me as being buggy with multiplayer it's worth checking to make sure.

@bengardner
Copy link
Collaborator

There is only one item network.
If there is a multiplayer game that is not co-op and there are multiple competing forces, then they would share the item network. Probably not desired.
I've not played a game with multiple competing teams. Not sure which mod would enable that.

@year6b7a
Copy link
Owner Author

This is intended for multiplayer games where everyone is on the same team. This is mainly to test that UI state is correctly stored per-player rather than globally.

@bengardner
Copy link
Collaborator

I finally got around to some LAN play and noticed a really annoying behavior with the usual network latency.

When you click on a chest, the "normal" chest dialog pops up and is displayed for a few ticks before it is replaced with the custom dialog.

That obviously doesn't happen on a single player game where there is no latency.
I have no idea what to do about that. We'd have to find a way to suppress the original chest UI.

Good news is that I didn't hit any desyncs.

@year6b7a
Copy link
Owner Author

year6b7a commented Oct 4, 2023

Hmm that's super strange. I'm not doing anything fancy with the GUI code so curious if other mods run into this issue as well. If there's an easy fix I'd be happy to merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants