Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: minor issues and web-lib #3

Merged
merged 3 commits into from Jun 17, 2022
Merged

patch: minor issues and web-lib #3

merged 3 commits into from Jun 17, 2022

Conversation

Majorfi
Copy link
Contributor

@Majorfi Majorfi commented Jun 17, 2022 •
edited

  • Enable 1337 support for all
  • Remove YEARN_PARTNER_CONTRACT_ADDRESS env variable to use the values from the web-lib (networks[chainID].partnerContractAddress from useSettings()). Data can be found here
  • On the DepositCard, prevent the input from updating after an approval or once something is already typed before the initial data load
  • Bump packages
  • Add link redirect to homepage onClick on Logo
  • Fix extra multicall on invalid chain on chain switch

@Majorfi Majorfi added the enhancement New feature or request label Jun 17, 2022
@Majorfi Majorfi requested a review from saltyfacu June 17, 2022 09:31
@Majorfi Majorfi self-assigned this Jun 17, 2022
@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
macarena-finance ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 10:25AM (UTC)

saltyfacu
saltyfacu approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@saltyfacu saltyfacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Majorfi Majorfi merged commit ce0439c into main Jun 17, 2022
@Majorfi Majorfi deleted the patch-1 branch June 17, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltyfacu saltyfacu saltyfacu approved these changes

Assignees

@Majorfi Majorfi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Majorfi @saltyfacu