Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setRewards() in BaseStrategy should be settable by gov. #467

Closed
pandadefi opened this issue Sep 1, 2021 · 2 comments
Closed

setRewards() in BaseStrategy should be settable by gov. #467

pandadefi opened this issue Sep 1, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p2 important

Comments

@pandadefi
Copy link
Contributor

Request from @poolpitako

setRewards() in BaseStrategy should be settable by gov.

Todo:

  • add the changes.
  • cherry-pick the changes on older version and tag a new version
@milkyklim milkyklim added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p2 important labels Sep 30, 2021
@jhb10c
Copy link
Contributor

jhb10c commented Oct 8, 2021

Hey @pandadefi. I would like to work on this. If I understand this, the setRewards function should have the modifier changed from _onlyStrategist() to _onlyGovernance()? If there are any specifications, could you provide more info?

@pandadefi
Copy link
Contributor Author

pandadefi commented Oct 8, 2021 •
edited
Loading

You will need a modifier that let's both governance and strategist set the rewards.
you will also have to change the tests so that's tested

@jhb10c jhb10c mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p2 important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@milkyklim @jhb10c @pandadefi