Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically verify sources on deployment #80

Closed
fubuloubu opened this issue Nov 13, 2020 · 6 comments
Closed

Automatically verify sources on deployment #80

fubuloubu opened this issue Nov 13, 2020 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time

Comments

@fubuloubu
Copy link
Member

Brownie needs this: eth-brownie/brownie#411

@fubuloubu fubuloubu added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 13, 2020
@storming0x storming0x assigned storming0x and unassigned storming0x Jan 11, 2021
@saltyfacu saltyfacu added this to Low priority in Vaults & Strategies Feb 2, 2021
@saltyfacu saltyfacu added the p2 important label Feb 4, 2021
@ghost
Copy link

ghost commented Feb 7, 2021

#188

@fubuloubu
Copy link
Member Author

fubuloubu commented Feb 8, 2021

Verify #188 solves this by deploying a Vault on Ropsten, and we can close

@ghost
Copy link

ghost commented Feb 9, 2021

The issue was:

TypeError: Etherscan does not support API verification of source code for vyper contracts. You need to verify the source manually.

But that was tested on kovan.

@fubuloubu
Copy link
Member Author

Oh weird, so Kovan works but Mainnet doesn't? Or just Ropsten doesn't?

I guess make sure the script can handle that failing

@ghost
Copy link

ghost commented Feb 9, 2021

I got this issue on kovan, maybe other networks aren't behaving the same way but I don't think that's an issue with the network more of an issue with etherscan.


I can try deploying on ropsten.

@saltyfacu saltyfacu moved this from Backlog to In progress in Vaults & Strategies Feb 12, 2021
@fubuloubu fubuloubu added p3 Fix if time and removed p2 important labels Mar 23, 2021
@ghost
Copy link

ghost commented May 19, 2021

TypeError: Etherscan does not support API verification of source code for vyper contracts. You need to verify the source manually

Vaults & Strategies automation moved this from In progress to Done Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed p3 Fix if time
Projects
Development

No branches or pull requests

4 participants