Skip to content
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.

Syntaxis changes and color fix #2

Open
turtlemoji opened this issue Mar 2, 2022 · 0 comments
Open

Syntaxis changes and color fix #2

turtlemoji opened this issue Mar 2, 2022 · 0 comments

Comments

@turtlemoji
Copy link

turtlemoji commented Mar 2, 2022

Proposed changes:

  • Modify the theme export from dark to something more specific and camelcase, like DarkThemeColors or etc.
  • the dark theme has a wrong color (extra character)
  • Modify kebab case to camelcase in color vars, like, primary-variant would be primaryVariant. This is since when used, if it is kebab case, you should have to do dark.colors['primary-variant'] instead of just dark.colors.primaryVariant. And would look inconsistent since with small ones like primary, it will indeed be dark.colors.primary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant