Fix scoping bug in HMC

TuringLang · Mar 24, 2017 · dffcb77 · dffcb77
1 parent c41c920
commit dffcb77
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/samplers/hmc.jl b/src/samplers/hmc.jl
@@ -65,6 +65,9 @@ function step(model, data, spl::Sampler{HMC}, varInfo::VarInfo, is_first::Bool)
 
     dprintln(2, "sampling momentum...")
     p = Dict(k => randn(length(varInfo[k])) for k in keys(varInfo))
+    if spl != nothing && ~isempty(spl.alg.space)
+      p = filter((k, p) -> getsym(varInfo, k) in spl.alg.space, p)
+    end
 
     dprintln(2, "recording old H...")
     oldH = find_H(p, model, data, varInfo, spl)

diff --git a/test/gibbs.jl b/test/gibbs.jl
@@ -13,7 +13,7 @@ x = [1.5 2.0]
   s, m
 end
 
-gibbs = Gibbs(1000, PG(16, 8, :s), HMC(2, 0.1, 4, :m))
+gibbs = Gibbs(1000, PG(20, 4, :s), HMC(2, 0.1, 4, :m))
 chain = @sample(gibbstest(x), gibbs)
 
 Turing.TURING[:modelex]