New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#105 pdd should store github user name not real name #107
Conversation
Job #107 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 98.34% 98.49% +0.14%
==========================================
Files 9 9
Lines 242 265 +23
==========================================
+ Hits 238 261 +23
Misses 4 4
Continue to review full report at Codecov.
|
lib/pdd/source.rb
Outdated
|
||
def get_json(query) | ||
uri = URI.parse(query) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, corrected
@a6cexz how do you know that this code works? |
@yegor256 I've added test case for getting github login from author email |
@a6cexz get rid of empty lines inside method bodies: https://www.yegor256.com/2014/11/03/empty-line-code-smell.html Aside from that, I think this functionality should be backward compatible. I mean, if we can find the GitHub account name, we set author to |
@yegor256 done |
@rultor merge |
Job |
The job #107 is now out of scope |
Use github search api to obtain github login using author email