Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#105 pdd should store github user name not real name #107

Merged
merged 5 commits into from Jul 7, 2018

Conversation

a6cexz
Copy link
Contributor

@a6cexz a6cexz commented Jul 6, 2018

Use github search api to obtain github login using author email

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2018

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label Jul 6, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 6, 2018

Job #107 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #107 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   98.34%   98.49%   +0.14%     
==========================================
  Files           9        9              
  Lines         242      265      +23     
==========================================
+ Hits          238      261      +23     
  Misses          4        4
Impacted Files Coverage Δ
lib/pdd/source.rb 97.82% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7f298...5bad241. Read the comment docs.


def get_json(query)
uri = URI.parse(query)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, corrected

@yegor256
Copy link
Member

yegor256 commented Jul 6, 2018

@a6cexz how do you know that this code works?

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2018

@yegor256/z everybody who has role REV is banned at #107; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@a6cexz
Copy link
Contributor Author

a6cexz commented Jul 6, 2018

@yegor256 I've added test case for getting github login from author email

@yegor256
Copy link
Member

yegor256 commented Jul 6, 2018

@a6cexz get rid of empty lines inside method bodies: https://www.yegor256.com/2014/11/03/empty-line-code-smell.html

Aside from that, I think this functionality should be backward compatible. I mean, if we can find the GitHub account name, we set author to @yegor256. If we can't find it, we leave it as Yegor Bugayenko. In other words, if we find it, we start with @.

@a6cexz
Copy link
Contributor Author

a6cexz commented Jul 7, 2018

@yegor256 done

@yegor256
Copy link
Member

yegor256 commented Jul 7, 2018

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 7, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5bad241 into cqfn:master Jul 7, 2018
@rultor
Copy link
Collaborator

rultor commented Jul 7, 2018

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@0crat 0crat removed the scope label Jul 7, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

Job gh:yegor256/pdd#107 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

The job #107 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants