Fix Prototype Pollution

swordev · Oct 9, 2020 · c2f8454 · c2f8454
1 parent bf8b1ff
commit c2f8454
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/dist/merge.browser.min.js b/dist/merge.browser.min.js
diff --git a/dist/merge.browser.test.js b/dist/merge.browser.test.js
@@ -276,7 +276,7 @@ function _merge(isClone, isRecursive, items) {
         if (!isPlainObject(item))
             continue;
         for (var key in item) {
-            if (key === '__proto__')
+            if (key === '__proto__' || key === 'constructor' || key === 'prototype')
                 continue;
             var value = isClone ? clone(item[key]) : item[key];
             result[key] = isRecursive ? _recursiveMerge(result[key], value) : value;

diff --git a/lib/src/index.js b/lib/src/index.js
@@ -69,7 +69,7 @@ function _merge(isClone, isRecursive, items) {
         if (!isPlainObject(item))
             continue;
         for (var key in item) {
-            if (key === '__proto__')
+            if (key === '__proto__' || key === 'constructor' || key === 'prototype')
                 continue;
             var value = isClone ? clone(item[key]) : item[key];
             result[key] = isRecursive ? _recursiveMerge(result[key], value) : value;

diff --git a/src/index.ts b/src/index.ts
@@ -85,7 +85,7 @@ function _merge(isClone: boolean, isRecursive: boolean, items: any[]) {
 			continue
 
 		for (const key in item) {
-			if (key === '__proto__') continue
+			if (key === '__proto__' || key === 'constructor' || key === 'prototype') continue
 			const value = isClone ? clone(item[key]) : item[key]
 			result[key] = isRecursive ? _recursiveMerge(result[key], value) : value
 		}