Added "controlsBackgroundColor" and fixed the Android example #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please make separate PRs for example and backgroundColor's control? Right now it has 80 files changed and 3200 LOC added, its quite hard to make sense of |
|
is this changes available in image_painter: ^0.4.6 ? |
i don't think so but you can check my fork, i did some changes to fit my personal needs, i did some visual changes and changed the zoom behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So first of all i'm sorry if i'm doing something wrong, it's my first time on contributing to a repo but i'm willing to help or do anything to make this easier.
About the changes, i added the field "controlsBackgroundColor" to all of the constructors, a simple thing but if this goes well i'm planning on keep contributing to this repo, i would really appreciate any advice.
Also i made another example, it just loads an image for editing using image_picker package, there were a lot of problems about migration but i think is fixed now. The example is just a full screen button that shows a ImagePicker, then a ImagePainter allows editing. The black background color was achieved by simple using a Stack, where the bottom buttons are also placed.