Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding Updates #22

Open
jefferypalmer opened this issue Jan 9, 2020 · 1 comment
Open

Encoding Updates #22

jefferypalmer opened this issue Jan 9, 2020 · 1 comment

Comments

@jefferypalmer
Copy link

Great project! We have added the base support for encoding a class to a binary AIS message as well in our fork and wondering if you're interested in pulling in these updates?

https://github.com/darren1713/AisParser/tree/DotNetStandard

There is a few notes for universal use:
Expand the testing framework to include encoding
Add the encoding function for text (not exactly sure about the exact character transformation required)
Add encode function for remaining message types after text field encoding

@chrisrichards
Copy link
Member

Thanks for this, would love to bring these changes in. If you create a pull request we can take it from there. A couple of points though:

  • I’d like to keep it on netstandard2.0 if possible
  • could do with some tests for the binary encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants