Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geoip_detect2_shortcode_get_property more general #84

Closed
benjaminpick opened this issue Jun 8, 2020 · 4 comments
Closed

Make geoip_detect2_shortcode_get_property more general #84

benjaminpick opened this issue Jun 8, 2020 · 4 comments

Comments

@benjaminpick
Copy link
Member

benjaminpick commented Jun 8, 2020

There are use cases that need more than 2/3 depth - when using ipstack, the data is in extra.original. ...

https://symfony.com/doc/current/components/property_access.html

$propertyAccessor = PropertyAccess::createPropertyAccessorBuilder()->enableMagicCall();

$propertyName = toCamelCase($propertyName);
try {
$propertyValue = $propertyAccessor->getValue($object, $propertyName);
} catch(\Exception $e) {
$propertyValue = '';
}
@benjaminpick
Copy link
Member Author

@benjaminpick
Copy link
Member Author

This works now BUT this raises the bar to PHP 7.1 . I'm not sure I want to do that.

@benjaminpick
Copy link
Member Author

Downgrade property Access to 3.4 - EOL is November 2021

@benjaminpick
Copy link
Member Author

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant