Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor applicable plugins to all inherit from RegexBasedDetector #102

Closed
KevinHock opened this issue Dec 12, 2018 · 1 comment
Closed

Refactor applicable plugins to all inherit from RegexBasedDetector #102

KevinHock opened this issue Dec 12, 2018 · 1 comment
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.

Comments

@KevinHock
Copy link
Collaborator

Where applicable plugins are currently the BasicAuth, Keyword and PrivateKey plugins
@KevinHock KevinHock added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. good first issue The issue can be tackled by someone who has little to no knowledge about the project. nice to have labels Dec 12, 2018
@domanchi domanchi mentioned this issue Dec 19, 2018
Merged
@joshuarli
Copy link
Contributor

joshuarli commented Dec 19, 2018 •
edited
Loading

Fixed in #103. Note that KeywordDetector wasn't refactored due to incompatible changes made in #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KevinHock @domanchi @joshuarli