Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configparser requirement not in setup.py #28

Closed
KevinHock opened this issue Jun 15, 2018 · 0 comments · Fixed by #30
Closed

configparser requirement not in setup.py #28

KevinHock opened this issue Jun 15, 2018 · 0 comments · Fixed by #30

Comments

@KevinHock
Copy link
Collaborator

KevinHock commented Jun 15, 2018

While testing what I uploaded to Test PyPI, I did detect-secrets --help (on Python 2), and got:

ImportError: No module named configparser (high_entropy_strings.py)

flake8, in requirements-dev.txt requires configparser, so we never ran into this during make test, 😮 pretty sneaky!

We should make a make test w/ setup.py dependencies only option from the Makefile.

But for now, python-future suggest doing from configparser import ConfigParser so that is what I will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant