Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baselines break with version bumps #37

Closed
domanchi opened this issue Jun 20, 2018 · 3 comments
Closed

baselines break with version bumps #37

domanchi opened this issue Jun 20, 2018 · 3 comments

Comments

@domanchi
Copy link
Contributor

domanchi commented Jun 20, 2018

Currently, baselines have no notion of which version of detect-secrets created it. This makes things slightly annoying, because with a major version bump, it could invalidate old baselines, requiring the user to recreate the baseline to be compliant once again.

At the very least, we should have baselines know which detect-secrets version created it, so we can be aware when this happens.

E.g. #26

@KevinHock
Copy link
Collaborator

KevinHock commented Jun 20, 2018

0.8.2 is the original old version, 0.8.8 is a new, breaking version. Due to detect-secrets thinking the secrets that have the same hash but different types are different. (https://github.com/Yelp/detect-secrets/pull/26/files was the change you will notice if you update to 0.8.8)

@KevinHock
Copy link
Collaborator

Note: If we don't update/change the plugin version types in the future, this is relatively preventable IMO

@KevinHock
Copy link
Collaborator

A related aside: I didn't update the CHANGELOG when I bumped, in a rush. Feel free to not approve my next PR until I do so. (May add emojis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants