Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace moshi with kotlinx-serialization #152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agologan
Copy link
Contributor

@agologan agologan commented Jul 21, 2021

This PR extends on #136. There's still work to be so external input is more then welcome:

Changes that should be discussed:

  • replaced ZonedDateTime with Instant from kotlinx-datetime - while this logically correct it does reduce all datetime representations to Zulu timezone
  • replaced number from BigDecimal to double - there is no official kmp support for BigDecimal which is not great because double is an approximation
  • replaced object with JsonObject - while using Json* classes is more type-safe it does modify the API heavily

As you can see most problems are around unsupported types which we could support via the Java classes but would still require some serialization changes maybe via contextual serialization?

The last problematic point is regarding nullability. While deserialization works as expected serialization implicitly omits null values. As far as I can tell these could be added back if the integrator passes in encodeDefaults: true on the JsonConfiguration. The x-nullable vendor extension just states null as a valid value and doesn't imply the client should explicitly send null to define a property as missing so maybe this is not actually a problem.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #152 (2b0a77f) into master (b2f2c2f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
- Coverage     71.95%   71.90%   -0.05%     
  Complexity      139      139              
============================================
  Files            11       11              
  Lines           574      573       -1     
  Branches         75       75              
============================================
- Hits            413      412       -1     
  Misses          118      118              
  Partials         43       43              
Impacted Files Coverage Δ
.../src/main/java/com/yelp/codegen/KotlinGenerator.kt 84.42% <ø> (ø)
...ain/java/com/yelp/codegen/utils/KotlinLangUtils.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f2c2f...2b0a77f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant