Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager and Linux support #41

Closed
wants to merge 11 commits into from

Conversation

novi
Copy link

@novi novi commented Mar 25, 2018

Added Package.swift and Linux support. It passes all tests on macOS and Linux.

And I have made changes to Xcode based project(for Cocoapods, Carthage):

  • add BitcoinKitXcode compiler flag to change import declaration

BitcoinKit.xcodeproj will conflict with Swift Package Manager generated xcodeproj. But it not affects for usage but for development.

@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files          47       47           
  Lines        3241     3241           
  Branches       58       58           
=======================================
  Hits         1691     1691           
  Misses       1546     1546           
  Partials        4        4
Impacted Files Coverage Δ
Sources/BitcoinKit/GetBlocksMessage.swift 0% <ø> (ø)
Sources/BitcoinKit/ByteStream.swift 0% <ø> (ø)
Sources/BitcoinKit/InventoryMessage.swift 0% <ø> (ø)
Sources/BitcoinKit/ServiceFlags.swift 0% <ø> (ø)
Sources/BitcoinKit/GetDataMessage.swift 0% <ø> (ø)
Sources/BitcoinKit/AddressMessage.swift 0% <ø> (ø)
Sources/BitcoinKit/Script.swift 54.54% <ø> (ø)
Sources/BitcoinKit/HDWallet.swift 0% <ø> (ø)
Sources/BitcoinKit/BloomFilter.swift 43.24% <ø> (ø)
Sources/BitcoinKit/PaymentURI.swift 82.22% <ø> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ba98d...ca2f641. Read the comment docs.

@usatie
Copy link
Member

usatie commented Aug 10, 2018

Hi, @novi !
Thanks for dropping us this PR.
I am one of the new maintainer of this project.

And I am planning to merge our BIG PR #69 first, but it will surely conflict a large part of you PR.
I'm sorry, can you create the PR again after we merged #69 ?

P.S.
I decided to merge this PR first.
So please just resolve the current conflict!

@usatie
Copy link
Member

usatie commented Aug 10, 2018

@GitCash send 5000 bits to @novi .
Thanks for dropping us a PR!
This is just a small tip!

@GitCash
Copy link

GitCash commented Aug 10, 2018

Hey novi, user usatie tipped you 5000 bits in Bitcoin Cash ( ~ $3.005 ).

Click here to claim it!

You can also add the "thumbs down" reaction to usatie's comment above to prevent future tips.

@usatie
Copy link
Member

usatie commented Aug 10, 2018

@novi now I could resolve the conflict between novi:work/package-swift and yenom:master.
So can you resolve the current conflict and push the change?
I will merge this PR first, and then, I'll resolve the conflict between BitcoinCashKit:master and yenom:master!

@novi
Copy link
Author

novi commented Aug 13, 2018

Hello. I will check them later.

@usatie
Copy link
Member

usatie commented Aug 13, 2018

@novi Hi, thank you for your help!

@usatie
Copy link
Member

usatie commented Aug 16, 2018

@novi Thanks for dropping us PR, we already merged your branch to this branch, so will close this PR.
c01df11

I thought your commits going to be included, but it turn out to be not...
So sorry for that.

@usatie usatie closed this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants