Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether to use configstore or <package name> should be a *user* option #69

Closed
OJFord opened this issue May 30, 2020 · 1 comment
Closed

Comments

@OJFord
Copy link

OJFord commented May 30, 2020

It shouldn't be up to the package whether to store in ~/.config/configstore/ or in ~/.config/<pkgname>/, it should be up to the user.

Better: respect the XDG base directory specification, or do that and further add $<PKGNAME>_HOME env var option.

I came to this repo wondering where the hell ~/.config/configstore came from, because I haven't installed any 'configstore'. As #27 says, having some random secondary bucket for a select bunch of different program/package's configs is unconventional.

@sindresorhus
Copy link
Member

This is too late to change now. Would be too much of a breaking change. However, we have an option to change the default now: https://github.com/yeoman/configstore#globalconfigpath

Also, the more modern alternative to configstore uses the correct location: https://github.com/sindresorhus/conf

Package consumers of configstore are free to support user-config to set the location, but this is not something we plan to support built-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants