Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requiring Node.js 10+? #75

Closed
takenspc opened this issue Mar 29, 2021 · 2 comments · Fixed by #76
Closed

Requiring Node.js 10+? #75

takenspc opened this issue Mar 29, 2021 · 2 comments · Fixed by #76

Comments

@takenspc
Copy link
Contributor

Node.js 10 LTS introduced recursive fs.mkdirSync so that we can drop make-dir from dependencies.
https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_mkdirsync_path_options

If it is fine, I will open a pull request to drop make-dir.
@sindresorhus
Copy link
Member

PR welcome.

@takenspc takenspc mentioned this issue Mar 31, 2021
Merged
@takenspc
Copy link
Contributor Author

I opened #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace make-dir with fs.mkdirSync
2 participants
@sindresorhus @takenspc