Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated types in @types/yeoman-environment #273

Closed
a-b-r-o-w-n opened this issue Mar 12, 2021 · 11 comments
Closed

outdated types in @types/yeoman-environment #273

a-b-r-o-w-n opened this issue Mar 12, 2021 · 11 comments

Comments

@a-b-r-o-w-n
Copy link

The latest release of the @types/yeoman-environment package is 2.10.2

I know the major was just bumped a week ago, but any chance we can get the typings updated soon?

@github-actions
Copy link
Contributor

This issue is stale because it has been open with no activity. Remove stale label or comment or this will be closed

@github-actions github-actions bot added the stale label Apr 13, 2021
@a-b-r-o-w-n
Copy link
Author

Commenting to remove stale label. This is still needed.

@manuth
Copy link

manuth commented May 22, 2021

@a-b-r-o-w-n is there something specific missing in @types/yeoman-environment?

@cgranade
Copy link

It looks like Environment.run is still listed as taking a callback parameter in @types/yeoman-environment@v2.2.3, but it was changed to an async method in yeoman-environment@3.4.1 such that the TypeScript compiler complains when awaiting the result of .run.

@tdashworth
Copy link

Hi, this still hasn't been resolved.

Is anyone actively working on this?

@GerbenRampaart
Copy link

Yes I'm running into this as well. I thought I was overlooking something.

@tdashworth
Copy link

I'm not even sure which version it's based on, maybe v2.x.x.

If I get the time, I'll try to contribute back some updated types although the docs site isn't terribly informative, especially around the TerminalAdapter - a key extension point.

@tburny
Copy link

tburny commented Nov 17, 2021

I also ran into this and got quite frustrated. Writing Yeoman generators is already a bit difficult, but writing a custom cli Frontend for a set of generators is nearly impossible if Your Typescript compiler tells you there are issues that practically only exist in the type definition files, but not in the code of itself.

Still thanks a lot for developing and maintaining Yeoman, it seems to be one of the only reasonable tools on the market (besides degit, which has a different approach).

@manuth
Copy link

manuth commented Feb 4, 2022

I finally found some time to refactor the type declarations of yeoman-environment.
I opened up a new PR just a few seconds ago. Stay tuned.

DefinitelyTyped/DefinitelyTyped#58614

@tdashworth
Copy link

That's amazing! Thank you @manuth, I'll take a look now.

@mshima
Copy link
Member

mshima commented Jan 15, 2024

yeoman-enviroment has built-in types now.

@mshima mshima closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants