Issue with v4 with local namespaces

[nvuillam]

I'm trying to upgrade in v4 because v3.x.x crashes when called from a JS module

But now I see the following error

For help, see: https://nodejs.org/en/docs/inspector
file:///C:/git/megalinter/mega-linter-runner/node_modules/yeoman-environment/dist/environment-base.js:205
                throw new TypeError(chalk.red(`You don't seem to have a generator with the name “${namespace?.generatorHint}” installed.`) +   
                      ^

TypeError: You don't seem to have a generator with the name “undefined” installed.

Here is how yeoman-environment is called

Do you have any tip ? :)

[github-actions]

This issue is stale because it has been open with no activity. Remove stale label or comment or this will be closed

[strmer15]

@mshima Can this be reopened? It looks like a problem with the parser in @yeoman/namespace not allowing local paths. I've opened yeoman/yeoman-api#5 for that, but this package would need to be updated with any new version.

[mshima]

Local paths should be converted to a valid namespace here:

environment/src/environment-base.ts

Lines 272 to 274 in f1bfab3

	const resolved = await resolveModulePath(namespaceOrPath);
	if (resolved) {
	const namespace = this.namespace(resolved);

[strmer15]

Ah, ok - thanks for that info! Looks like it's throwing an error because the resolvedOrigin in the resolveModulePath function is undefined. If I comment out the else block in that function it seems to work correctly again for local paths.

Should I create a PR to remove that (or adjust that logic)? Or are you already working on a fix?

[mshima]

Please go ahead.

[strmer15]

Please go ahead.

Thanks! I've created #504 to address it, let me know if that seems good.

[mshima]

The sample usage is wrong, the bug is not valid. Should be:

await env.run([generatorPath]);

@strmer15 your usage looks related to relative paths.
Please post your use case in a new issue.