Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Bootstrap glyphicons omitted for CSS-only builds #1126

Closed
brian428 opened this issue Jun 25, 2015 · 2 comments
Closed

Bootstrap glyphicons omitted for CSS-only builds #1126

brian428 opened this issue Jun 25, 2015 · 2 comments

Comments

@brian428
Copy link

If standard CSS is chosen for the build, the Bootstrap glyphicons (from bower_components/bootstrap/dist/fonts) are not included during a build.

I see that _build.js has this conditional on line 92:

<% if (props.ui.key === 'bootstrap' && props.cssPreprocessor.extension === 'styl') { -%>
  return gulp.src($.mainBowerFiles().concat('bower_components/bootstrap-stylus/fonts/*'))
<% } else { -%>
  return gulp.src($.mainBowerFiles())
<% } -%>

I'm wondering if that just needs to be something like this?

<% if (props.ui.key === 'bootstrap') { -%>
  return gulp.src($.mainBowerFiles().concat('bower_components/bootstrap*/**/fonts/*'))
<% } else { -%>
  return gulp.src($.mainBowerFiles())
<% } -%>

Either that, or a separate else if to explicitly handle bootstrap+css mode?

@eddiemonge
Copy link
Member

What is _build.js? This is probably a duplicate of #1116

@brian428
Copy link
Author

Oops, sorry! I had meant to open this issue on the generator-gulp-angular project! Apologies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants