props or just variable

[hueitan]

In the template file

for example

{
  "name": "<%= slugname %>",
  "version": "0.0.0",
  "main": "lib/<%= slugname %>.js",
  "description": "<%= props.description %>",<% if (props.homepage) { %>
  "homepage": "<%= props.homepage %>",<%}%>
  "bugs": "<%= repoUrl %>/issues",
  "author": {
    "name": "<%= props.authorName %>",
    "email": "<%= props.authorEmail %>"<% if (props.authorUrl) { %>,
    "url": "<%= props.authorUrl %>"<% } %>
  }
}

In this case we have variable slugname props.homepage

Can we select just one type

1. all using props
   or
2. all using variable (assign all props to a variable, let props.authorName => authorName)

Easier for maintenance.

Thanks

[hemanth]

I would vote for all props.

[hueitan]

One question.

How do I support variable like safeSlugname ? That's not from props.

[hemanth]

In what scenario it won't be from props? As of now it's slugified props.name

[hueitan]

safeSlugname is original from slugname which is from the props

But sometimes we need other variables which are not being given by user in props

In my opinion, maybe variable is cool enough.

In the template, we don't need <% props.xxxx %> props again. Just use <% xxxx %>

But we need to assign the variable from props in the index.js, that's the trouble works.

[hemanth]

In that case the variables are a good solution.

What says @sindresorhus @SBoudrias ?

[hueitan]

Total 10 props, I think more than 10 will cause dislike 😢

var prompts = [{
      name: 'description',
      message: 'Description',
      default: 'The best module ever.'
    }, {
      name: 'homepage',
      message: 'Homepage'
    }, {
      name: 'license',
      message: 'License',
      default: 'MIT'
    }, {
      name: 'githubUsername',
      message: 'GitHub username'
    }, {
      name: 'authorName',
      message: 'Author\'s Name'
    }, {
      name: 'authorEmail',
      message: 'Author\'s Email'
    }, {
      name: 'authorUrl',
      message: 'Author\'s Homepage'
    }, {
      name: 'keywords',
      message: 'Key your keywords (comma to split)'
    }, {
      name: 'cli',
      message: 'Do you need cli tools?',
      default: 'yes'
    }, {
      name: 'browser',
      message: 'Do you need browserify?',
      default: 'yes'
    }];

[hemanth]

We could just stick on the github user name or author name and skip email and URL?

[hueitan]

I think email is still needed.
But url and author name can retrieve from user name

[hemanth]

👍 So be it?

Update: @huei90 Lets reduce it to bare minimal.

[faustman]

Hi guys,
how your affairs with this task?

I want fix some trailing spaces in package.json.
Should I wait when you finish this task?

[hemanth]

@faustman Go ahead, this is yet to be finalized.

[hueitan]

@faustman Go Ahead!

[hemanth]

@huei90 If you notice the latest _package.json expect keywords all of them are props.

[faustman]

no action from me,
no more trailing spaces since 6adf1f4

[hemanth]

👍