-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do Bootstrap plugins get built as a separate file? #590
Comments
You mean bootstrap's built-in js plugins? The way how they are inserted into html file? |
@neilhem yeah, Bootstrap's JS plugins are inserted into a separate useref comment block, but it could just as well be a part of the Now that I think about it, I remember I wanted to change it previously, but it was tricky… |
Maybe we should remove integration with boostrap plugins on generator bootstrap & include them via wiredep |
@neilhem good idea! |
What is the "right" solution for now, if I don't want another request? Thanks |
One way is to include them all in the <!-- build:js scripts/vendor.js -->
<!-- bower:js -->
<!-- endbower -->
<!-- insert Bootstrap plugins here -->
<!-- endbuild --> |
wiredep remove this hardcoded files in next running... :( |
Wiredep removes everything between <!-- bower:js -->wiredep injected scripts here<!-- endbower --> Scripts which you don't want to be affected by wiredep you should put like this: <!-- build:js scripts/vendor.js -->
<!-- bower:js -->
<!-- endbower -->
wiredep will not update these scripts
<!-- endbuild --> |
I assume that this bug was fixed in #737. If not we can re-open it again 😃 |
Seems like we could save an HTTP request there, if I'm not missing something.
The text was updated successfully, but these errors were encountered: