Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp Build doesn't include JS lib #654

Closed
tuannguyenminh2086 opened this issue Apr 13, 2017 · 2 comments
Closed

Gulp Build doesn't include JS lib #654

tuannguyenminh2086 opened this issue Apr 13, 2017 · 2 comments

Comments

@tuannguyenminh2086
Copy link

tuannguyenminh2086 commented Apr 13, 2017

Dear,

I added some third-party JS in html: for examples: magicsuggest.js . But when I run GULP BUILD, it doesnt compile in plugins.js.

`

<script src="/bower_components/lodash/dist/lodash.min.js"></script>
<script src="/bower_components/jquery/dist/jquery.js"></script>

<!-- build:js scripts/plugins.js -->
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/affix.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/alert.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/dropdown.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/tooltip.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/modal.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/transition.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/button.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/popover.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/carousel.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/scrollspy.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/collapse.js"></script>
<script src="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/tab.js"></script>
<script src="/bower_components/bootstrap-select/dist/js/bootstrap-select.js"></script>
<script src="/bower_components/perfect-scrollbar/js/perfect-scrollbar.jquery.min.js"></script>
<script src="/bower_components/jQuery-contextMenu/dist/jquery.ui.position.min.js"></script>
<script src="/bower_components/jQuery-contextMenu/dist/jquery.contextMenu.min.js"></script>
<script src="/bower_components/magicsuggest/magicsuggest.js"></script>

<!-- endbuild -->

<!-- build:js scripts/main.js -->
<script src="scripts/main.js"></script>
<!-- endbuild -->`

And here is bower.json

screen shot 2017-04-13 at 11 20 12 am


Is there any limit of number lib we can include? I also have a problem when I add bootstrap-datepicker.js also.

Hope to get your reply soon.

@Trost123
Copy link
Contributor

Trost123 commented May 31, 2017

Does magicsuggest compile into plugins.js if you don't include all those bootstrap js?
This way we could tell if the problem is high file count or magicsuggest\datepicker lib.

@UlisesGascon
Copy link
Member

I assume that this bug was fixed in #737. If not we can re-open it again 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants