Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unusable generator: dist (or docs how to build dist) is buggy #752

Closed
azol opened this issue Feb 27, 2019 · 1 comment
Closed

unusable generator: dist (or docs how to build dist) is buggy #752

azol opened this issue Feb 27, 2019 · 1 comment
Labels

Comments

@azol
Copy link

azol commented Feb 27, 2019

very minimal install leads to buggy result.

Steps to reproduce:

  • scaffold
  • build dist as per documentation
  • check result
$ ls -al
total 0
drwxr-xr-x   2 az  staff   64 Feb 27 08:41 .
drwxr-xr-x  16 az  staff  512 Feb 27 08:41 ..
$ yo webapp
$ npm run build
$ tree dist/
dist/
├── apple-touch-icon.png
├── favicon.ico
├── fonts
├── images
├── index.html
├── robots.txt
├── scripts
│   ├── main.js
│   └── vendor.js
└── styles
    └── main.css
4 directories, 7 files

at least two problems here:

$ grep -l modernizr dist/index.html 
dist/index.html
$ grep -l node_modules dist/index.html 
dist/index.html

<script src="scripts/vendor/modernizr.js"></script> is what I get in the dist/index.html, but the file is missing

<link rel="stylesheet" href="/node_modules/bootstrap/dist/css/bootstrap.min.css"> is what is get in the dist/index.html, which is obviously totally wrong.

opening dist/index.html in regular browser visually confirms that at least styling is missing.

Fixes:

  • either fix docs for proper dist generation
  • or fix the code to generate usable result
@azol azol changed the title dist or docs how to build dist: buggy unusable generator: dist (or docs how to build dist) is buggy Feb 27, 2019
@silvenon silvenon pinned this issue Feb 27, 2019
@silvenon silvenon added the bug label Mar 4, 2019
@silvenon
Copy link
Member

silvenon commented Mar 6, 2019

These critical problems have hopefully been all fixed in v4.0.0-3! Let me know if there are any more problems.

@silvenon silvenon closed this as completed Mar 6, 2019
@silvenon silvenon unpinned this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants