Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

Default shim in main.js should also have conditionals around bootstrap code #95

Closed
farmersmc opened this issue Jun 20, 2013 · 1 comment

Comments

@farmersmc
Copy link

Is there a reason the bootstrap shim code isn't surrounded by conditional statements? Otherwise, if I don't choose Compass Bootstrap files, I still get this useless shim.

This:

    paths: {
        jquery: '../bower_components/jquery/jquery'<% if (compassBootstrap) { %>,
        bootstrap: 'vendor/bootstrap'<% } %>
    },
    shim: {
        bootstrap: {
            deps: ['jquery'],
            exports: 'jquery'
        }
    }
});

Should be:

    paths: {
        jquery: '../bower_components/jquery/jquery'<% if (compassBootstrap) { %>,
        bootstrap: 'vendor/bootstrap'<% } %>
    },
   <% if (compassBootstrap) { %> shim: {
        bootstrap: {
            deps: ['jquery'],
            exports: 'jquery'
        }
    }<% } %>
});
@passy
Copy link
Member

passy commented Jun 22, 2013

Good point. Do you want to submit a pull request for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants