Breaking change: copy => fs.copy does not work as expected (ignores sourceRoot)

[evil-shrike]

As continue #901

Previously there was copy method which assumed files inside sourceRoot. Now the method was removed (not documented anywhere), and using fs object is suggested (http://yeoman.io/authoring/file-system.html)

was working:

this.copy('path/to/file', 'path/to/file');

now failing, as there's no copy method now.
If change it to fs.copy:

this.fs.copy('path/to/file', 'path/to/file');

it's still failing, now inside mem-fs-editor\lib\actions\copy.js: AssertionError: Trying to copy from a source that does not exist: path/to/file

It turns out fs.copy ignores template path (sourceRoot).
So I have to add templatePath for the source file:

this.fs.copy(this.templatePath('path/to/file'), 'path/to/file');

very annoying as requires specifying templatePath for fs.copy call.
And it's also undocumented.

Also there are outdated and incorrect comment in code for sourceRoot - see https://github.com/yeoman/generator/blob/master/lib/index.js#L586

  /**
   * Change the generator source root directory.
   * This path is used by multiples file system methods like (`this.read` and `this.copy`)
   * @param  {String} rootPath new source root path
   * @return {String}          source root path
   */
sourceRoot(rootPath) 

[github-actions]

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days