Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file conflict resolutions #1040

Closed
avergos29 opened this issue Oct 2, 2017 · 4 comments
Closed

file conflict resolutions #1040

avergos29 opened this issue Oct 2, 2017 · 4 comments

Comments

@avergos29
Copy link

Hi,
Is it possible to modify the conflicter to use a custom merge tool in case of a conflict ?
If not, do you plan to make it possible in the future ?
Thanks

@SBoudrias
Copy link
Member

Hey @avergos29, we're open to receiving a PR adding this feature. Let me know if you need pointer to get started.

@guilhermevrs
Copy link

Hi @SBoudrias, I would definitely like a feature like that.

Can you give me a pointer to get started? I would like to try a few ideas on the subject

@SBoudrias
Copy link
Member

@guilhermevrs of course! I think you'd want to modify this file: https://github.com/yeoman/generator/blob/master/lib/util/conflicter.js#L138

I'd assume we should add a new option to the list; maybe "Resolve manually". And when we select this, we should generate a diff content and send this to the diff resolution tool (this is usually defined as an ENV variable on users OS)

As to passing the content, you might need to generate a temporary file and watch for changes to detect once the conflict is resolved. You might be able to grab some inspiration (or reuse) from https://github.com/mrkmg/node-external-editor

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2020

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Jan 1, 2020
@github-actions github-actions bot closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants