Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should allow - as part of directory name #1054

Closed
taoning2014 opened this issue Jan 27, 2018 · 2 comments
Closed

Should allow - as part of directory name #1054

taoning2014 opened this issue Jan 27, 2018 · 2 comments
Labels

Comments

@taoning2014
Copy link

When init project using yo, determineAppname is used to set default project name as the current directory name. However if the directory name is bar-foo(open node_modules of any project, you will find this name convention is quite usual than bar_foo). The following regex will replace - with space. Recommend change /[^\w\s]+?/g to /[^\w\s-]+?/g

return appname.replace(/[^\w\s]+?/g, ' ');

@SBoudrias
Copy link
Member

I'm not sure how I feel about changing that because it's kind of always been this way. Would it make sense for you to reassign this value yourself? In theory, there's nothing forcing you to use this.appname directly.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants