remove async lib

[jimmywarting]

The async lib are huge and you only use one function (series) at one place

generator/lib/util/conflicter.js

Line 4 in b1e62ec

const async = require('async');

generator/lib/util/conflicter.js

Lines 71 to 91 in b1e62ec

	resolve(cb) {
	cb = cb || (() => {});
	const resolveConflicts = conflict => {
	return next => {
	if (!conflict) {
	next();
	return;
	}
	this.collision(conflict.file, status => {
	// Remove the resolved conflict from the queue
	_.pull(this.conflicts, conflict);
	conflict.callback(null, status);
	next();
	});
	};
	};
	async.series(this.conflicts.map(resolveConflicts), cb.bind(this));
	}

I believe this dose the exact same thing, (I have not tested the code - it's a proposal, that i think i got right)

  resolve(cb) {
    cb = cb || (() => {});
    const iterator = this.conflicts.values();
    
    const resolveConflicts = iterator => {
      const {value:conflict, done} = iterator.next();

      // use this line if this.conflicts.entries() is being used instead
      // const {value:[i, conflict], done} = iterator.next();

      if (done) cb();
      else if (!conflict) resolveConflicts();
      else this.collision(conflict.file, status => {
        // Remove the resolved conflict from the queue
        _.pull(this.conflicts, conflict);
        conflict.callback(null, status);
        resolveConflicts(iterator);
      });
    };

    resolveConflicts(iterator);
  }

i saw over at node.green that array.values() was not so widely compatible but .entries() was so i also showed how to destruct using entries (also possible to remove destructing all together...)

[SBoudrias]

Might be able to also reuse something like https://www.npmjs.com/package/async-series ?

Either way, PR is welcomed as long as we support current Node LTS (>= 6)

[jimmywarting]

I don't think you need a library for that, just shown you how it could be done without any dependencies

[github-actions]

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days