Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator uses grouped-queue but does not depend on it #1189

Closed
flatiron32 opened this issue Mar 10, 2020 · 5 comments · Fixed by #1190
Closed

Generator uses grouped-queue but does not depend on it #1189

flatiron32 opened this issue Mar 10, 2020 · 5 comments · Fixed by #1190
Labels
Milestone

Comments

@flatiron32
Copy link
Contributor

This change broke my generator #1150

  ● Test suite failed to run

    Cannot find module 'grouped-queue/lib/subqueue' from 'index.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:276:11)
      at Object.<anonymous> (node_modules/yeoman-generator/lib/index.js:17:18)

My fix is to directly depend on grouped-queue directly.

@flatiron32 flatiron32 added the needs triage Awaiting triage label Mar 10, 2020
@mshima
Copy link
Member

mshima commented Mar 11, 2020

@flatiron32 can you confirm #1190 fixes this problem?

@mshima mshima added bug and removed needs triage Awaiting triage labels Mar 11, 2020
@flatiron32
Copy link
Contributor Author

I am not sure I know how to test correctly because. When I checkout branch v4.6.0 (the version I first experience a problem with), run npm link, and in my project run npm link yeoman-generator I don't have the failing tests any more. AFAIKT from diffing the package there is no change.
I think I need advice on how to test a local branch of yeoman-generator in my generator.

@mshima
Copy link
Member

mshima commented Mar 11, 2020

I normally test with npm install mshima/generator#master

@mshima
Copy link
Member

mshima commented Mar 11, 2020

Eslint was supposed to error with this missing dependency.

This patch will fail if you use custom priorities.
I will not add grouped-queue dependency here, because I will add min environment required for some features.
So I have plans to remove addSubQueue workaround.

@flatiron32
Copy link
Contributor Author

I confirm that #1190 will make my generator's tests pass.
v4.5.0 --> Pass
v4.6.0 --> Fail
V4.7.0 --> Fail
#1190 --> Pass
All with no changes to my generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants