Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest throws syntax error at L285 in index.js. #1192

Closed
ayesham opened this issue Mar 13, 2020 · 4 comments · Fixed by #1194
Closed

Jest throws syntax error at L285 in index.js. #1192

ayesham opened this issue Mar 13, 2020 · 4 comments · Fixed by #1194
Milestone

Comments

@ayesham
Copy link

ayesham commented Mar 13, 2020

Jest throws syntax error on L285 index.js at the following code:

try {
            SubQueue = require('grouped-queue/lib/subqueue');
          } catch {
            throw new Error(
              "The running environment doesn't have the necessary features to run this generator. Update it and run again."
            );
          }

Looks like it was recently added via:

b5e5c75#diff-6d186b954a58d5bb740f73d84fe39073R285

@ayesham
Copy link
Author

ayesham commented Mar 13, 2020

Should this be:

         try {
            SubQueue = require('grouped-queue/lib/subqueue');
          } catch (error) {
            throw new Error(
              "The running environment doesn't have the necessary features to run this generator. Update it and run again."
            );
          }

@ayesham
Copy link
Author

ayesham commented Mar 14, 2020

Thanks so much for your quick response to this issue. Is it possible to publish a patch for this one?

@mshima mshima added this to the v4.7.2 milestone Mar 14, 2020
@mshima
Copy link
Member

mshima commented Mar 14, 2020

Published.
Eslint was supposed to catch this error. :P

@ayesham
Copy link
Author

ayesham commented Mar 14, 2020

Hahahaha! Thanks! On the brighter side, robots can’t take our jobs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants