Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflictor should respect env cwd #1259

Closed
xyc opened this issue Aug 4, 2020 · 3 comments
Closed

conflictor should respect env cwd #1259

xyc opened this issue Aug 4, 2020 · 3 comments
Labels
needs triage Awaiting triage stale

Comments

@xyc
Copy link

xyc commented Aug 4, 2020

conflictor logs a relative file path from process.cwd() to file.path. It doesn't respect the cwd path set in environment. This mainly affects logging.

const rfilepath = path.relative(process.cwd(), file.path);

@xyc xyc added the needs triage Awaiting triage label Aug 4, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open more than 45 days with no activity. Remove stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale label Sep 19, 2020
@mshima
Copy link
Member

mshima commented Sep 19, 2020

I will take a look at next major version.

@mshima mshima removed the stale label Sep 19, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

This issue is stale because it has been open more than 45 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Awaiting triage stale
Projects
None yet
Development

No branches or pull requests

2 participants