Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xo is in dependencies instead of devDependencies #1282

Closed
manuth opened this issue Feb 22, 2021 · 3 comments
Closed

xo is in dependencies instead of devDependencies #1282

manuth opened this issue Feb 22, 2021 · 3 comments
Labels
needs triage Awaiting triage

Comments

@manuth
Copy link

manuth commented Feb 22, 2021

When having yeoman-generator as a dependency, it's impossible to use the @typescript-eslint/eslint-plugin in my project because yeoman-generator having xo as a normal dependency instead of a devDependency causes a conflict between ./node_modules/@typescript-eslint/eslint-plugin and ./node_modules/yeoman-generator/node_modules/@typescript-eslint/eslint-plugin.

The solution of this problem would be to remove xo from dependencies and add it to the devDependencies-list as recommended in the docs of xo:
https://github.com/xojs/xo#workflow

Before/after

 {
 	"name": "awesome-package",
 	"scripts": {
-		"test": "ava",
+		"test": "xo && ava"
 	},
 	"devDependencies": {
-		"ava": "^2.0.0"
+		"ava": "^2.0.0",
+		"xo": "^0.25.0"
 	}
 }
@manuth manuth added the needs triage Awaiting triage label Feb 22, 2021
@mshima
Copy link
Member

mshima commented Feb 22, 2021

Fixed in 5.0.1

@mshima mshima closed this as completed Feb 22, 2021
@mshima
Copy link
Member

mshima commented Feb 22, 2021

Thanks @manuth

@manuth
Copy link
Author

manuth commented Feb 22, 2021

You're welcome - thank you for the rapid fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants