this.addDevDependencies and this.addDependencies can improperly trigger conflict resolver

[ntucker]

Just because a comma is added when addDependencies runs it creates a conflict and prompts the user in addition to breaking the install process

[terenceodonoghue]

Running into this with yeoman-generator@^5.3.0. Can confirm that the trailing comma seems to be triggering the conflict resolver.

[ntucker]

@terenceodonoghue btw: one mistake I had was not awaiting these methods as they now return promises, which is why the conflict resolver was triggered.

This is still a problem for running yo on existing filesystems, but for completely new projects properly awaiting their return values should avoid this issue.

[terenceodonoghue]

@ntucker that fixed it, thanks! I replaced:

writing() {
  this.addDependencies([...])
}

with:

async writing() {
  await this.addDependencies([...])
}

Off-topic, but it's now failing for another reason: addDependencies and addDevDependencies attempt to resolve all packages against the public npm registry and ignores those I've defined in my .npmrc, thus the generator fails with a 404 error.

[mshima]

Closing, since it's resolved. The private repo problem is unrelated and should be discussed in the other issue.

[ntucker]

@mshima "This is still a problem for running yo on existing filesystems, but for completely new projects properly awaiting their return values should avoid this issue."

This conflict issue will appear if you have an existing package.json - which is often the case when you're using yo to add pieces to an existing project instead of just create a new one. (I assume this is the point of making yorc files)

[mshima]

If you want to force package.json to be written, you can do something like #1239.
Or write a .yo-resolve file with

package.json force

[ntucker]

Why is there a merging policy if the expectation is to only write to existing files if it's completely forced?

[mshima]

What are you spectating here?
To merge? To don’t generate at all? To use existing values?

The default is to merge, which is the better default for composing.
If you want to keep old values as default, you should load them.

this.addDependencies({
  …dependencies,
  …this.packageJson.getAll().dependencies
})