Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a flag to use config in proxymode #1395

Closed
Tcharl opened this issue Jan 18, 2023 · 1 comment
Closed

Introduce a flag to use config in proxymode #1395

Tcharl opened this issue Jan 18, 2023 · 1 comment
Labels

Comments

@Tcharl
Copy link

Tcharl commented Jan 18, 2023

Users are kinda disappointed when they use a dedicated variable to use config in proxyMode and another for other case.
Two different variables to manipulate the same instance (pointer) is quite confusing from a developper experience point of view.

i.e.

const jhipsterProxy = this.config.proxy();
this.config.defaults({ serviceDiscovery: 'consul' });
jhipsterProxy.serviceDiscovery = 'eureka' // leads to this.config now equals to 'eureka'

Would be nice to get a proxy flag instead, to activate this feature by default, or even to totally deactivate proxy mode

@github-actions
Copy link
Contributor

This issue is stale because it has been open with no activity. Remove stale label or comment or this will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant